Re: [PATCH 4/5] Add mdadm_no_degraded

[David Lehman <dlehman redhat com>]

On Wed, 2009-06-17 at 14:20 -0400, Jeremy Katz wrote:
> On Jun 17, 2009, at 2:17 PM, David Lehman wrote:
> > On Fri, 2009-06-12 at 14:33 +0200, Jacek Danecki wrote:
> >> Dan Williams wrote:
> >>> Jacek Danecki wrote:
> >>>> This patch adds new function used by activating md array for isw  
> >>>> format.
> >
> > Instead of duplicating the entire function to add one option, why not
> > add an optional/keyword argument "no_degraded" to the mdadd function.
> > The new prototype would be as follows:
> >
> > def mdadd(device, no_degraded=None):
> 
> True/False is probably clearer than None vs not None

In this case it would be fine to use False. I always use None as a
matter of habit so I don't end up making the mistake of using a mutable
object (eg: a list or dict) as a default argument.

> 
> Jeremy
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list