[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/2] Do not encourage VNC when doing kickstart text installs (#506534)



On Wed, 2009-06-17 at 08:31 -1000, David Cantrell wrote:
> Users expect kickstart installs to proceed as indicated in the ks file.
> If the user has selected text, we should just continue rather than
> stopping to encourage VNC use.
> ---
>  anaconda |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/anaconda b/anaconda
> index 969cc07..531041b 100755
> --- a/anaconda
> +++ b/anaconda
> @@ -756,7 +756,7 @@ if __name__ == "__main__":
>      if not opts.display_mode:
>          opts.display_mode = 'g'
>  
> -    if opts.display_mode == 't' and flags.vncquestion: #we prefer vnc over text mode, so ask about that
> +    if opts.display_mode == 't' and flags.vncquestion and not anaconda.isKickstart: #we prefer vnc over text mode, so ask about that
>          title = _("Would you like to use VNC?")
>          message = _("Text mode provides a limited set of installation options.  "
>                      "It does not allow you to specify your own partitioning "

I can't speak to the code, but I can say this is a small but important
change for users with a large pool of existing kickstart files.

Thanks David!
-James

Attachment: signature.asc
Description: This is a digitally signed message part


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]