[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/2] Do not encourage VNC when doing kickstart text installs (#506534)



On Jun 17, 2009, at 3:07 PM, David Cantrell wrote:
On Wed, 17 Jun 2009, Jeremy Katz wrote:

On Jun 17, 2009, at 2:31 PM, David Cantrell wrote:
Users expect kickstart installs to proceed as indicated in the ks file.
If the user has selected text, we should just continue rather than
stopping to encourage VNC use.

Concept seems okay, but maybe we should just set flags.vncquestion always in the opts.ksfile conditional a few lines above this?

diff --git a/anaconda b/anaconda
index 969cc07..e1c9fbc 100755
--- a/anaconda
+++ b/anaconda
@@ -745,8 +745,7 @@ if __name__ == "__main__":
            if vncS.vncconnectport == "":
                vncS.vncconnectport = earlyKS.vnc.port

-        if earlyKS.displaymode.displayMode != None:
-            flags.vncquestion = False
+        flags.vncquestion = False

    #
    # Determine install method - GUI or TUI

Looks simpler -- ack :)

Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]