[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [PATCH 07/14] Remove possibly unnecessary code in class NoDevFS
- From: David Lehman <dlehman redhat com>
- To: Discussion of Development and Customization of the Red Hat Linux Installer <anaconda-devel-list redhat com>
- Subject: Re: [PATCH 07/14] Remove possibly unnecessary code in class NoDevFS
- Date: Mon, 02 Mar 2009 10:11:47 -0600
Good one -- you are correct that it should be removed. I originally
implemented nodev filesystems using a static class attribute set by the
fstypes, but decided instead to subclass FS with NoDevFS.
On Sun, 2009-03-01 at 20:32 -1000, David Cantrell wrote:
> I cannot find anywhere that 'nodev' is used. I played around with
> variants on these two lines, but eventually ended up removing them
> to continue with testing.
> ---
> storage/formats/fs.py | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/storage/formats/fs.py b/storage/formats/fs.py
> index 511ac3c..f80a877 100644
> --- a/storage/formats/fs.py
> +++ b/storage/formats/fs.py
> @@ -933,8 +933,6 @@ class NoDevFS(FS):
>
> def __init__(self, *args, **kwargs):
> FS.__init__(self, *args, **kwargs)
> - if self.nodev and not self.device:
> - self.device = self.type
>
> def _deviceCheck(self, devspec):
> pass
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]