[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 6/8] Fix testing for whether a device requires networking.



> > There's no more isNetdev method, so we'll have to use the type of the object
> > as a test instead.
> 
> This will need some work. NetworkDevice is meant to represent a NIC.
> Now, looking at this, maybe we should create NetworkStorageDevice and
> have NFS, iSCSI, FCoE all subclass it.

Agreed, but I couldn't find anything that provided this information in
the current storage code.  In fact in your patching, you changed the
lines around this one but kept the rootdev.isNetdev in there so it
looked like you intended to come back and do something.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]