[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 5/8] Make sure _getResizeArgs() return lists of strings, add one for NTFS.



> The _getResizeArgs() methods need to return lists of strings since
> we pass that to the exec functions.  Add a _getResizeArgs() to the
> NTFS class.

Does it make more sense or make for cleaner code if resizeArgs is a
property?  It seems like we're using those a lot in the new storage
code.

Aside from that, this whole series of patches looks fine.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]