[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 5/8] Make sure _getResizeArgs() return lists of strings, add one for NTFS.



> diff --git a/storage/formats/fs.py b/storage/formats/fs.py
> index 9c61b59..d27b348 100644
> --- a/storage/formats/fs.py
> +++ b/storage/formats/fs.py
> @@ -300,8 +300,9 @@ class FS(DeviceFormat):
>          # instance of the new filesystem type.
>          self._type = self.migrationTarget
>  
> -    def _getResizeArgs(self):
> -        argv = [self.device, self.targetSize]
> +    @property
> +    def resizeArgs(self):
> +        argv = [self.device, "%d" % (self.targetSize,)]
>          return argv
>  
>      def doResize(self, *args, **kwargs):

Looks fine, though this is a patch against the previous patch.  So make
sure you merge them together so as to avoid the weirdo temporary commit
in the history.  You know?

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]