[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Ignore disk devices with missing media (#488800).



> Looks good, a bit tricky though.

Tricky is my way.

> Wouldn't it be better to raise an
> exception in most of the case where you currently simply return
> (such as add / remove partition) ?

We can certainly do that.  I guess it's a matter of what the callers
expect and how this code acts when being run on a real machine.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]