[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 5/6] Look for a PReP "partition" by examining the format, not the flags (#492426).



On Fri, 2009-03-27 at 16:11 -0400, Chris Lumens wrote:
> ---
>  booty/ppc.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/booty/ppc.py b/booty/ppc.py
> index 706f198..e49a865 100644
> --- a/booty/ppc.py
> +++ b/booty/ppc.py
> @@ -16,7 +16,7 @@ class ppcBootloaderInfo(bootloaderInfo):
>  
>          if machine == 'pSeries':
>              for dev in self.storage.fsset.devices:
> -                if dev.partedFlags[parted.PARTITION_PREP] and not dev.format.exists:
> +                if dev.format.type == "prepboot" and not dev.format.exists:

I'm not sure this is enough. If this is after we create the filesystems
and whatnot all of the device will have their "exists" attribute set to
True. This makes identifying non-preexisting devices difficult.

>                      retval.append(dev.path)
>          elif machine == 'PMac':
>              for dev in self.storage.fsset.devices:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]