Re: [PATCH] Do not raise UI dialog in stage2 if network is set in ks (#487503).

[Chris Lumens <clumens redhat com>]

> Asking in UI if ks settings fail is done depending on where we are in
> the flow (e.g. ask when we are being or are going to be interactive anyway),
> I'd appreciate checking my judgement here.

Yes, I think you are on the right track here.  Noting that this only
happens when ks=floppy or similar is a pretty good corner case - good
catch.

What do you think about doing the network.bringUp call in
kickstart.py:Network instead?  That way we've got this done in a central
place and don't need to worry about it for when we need a repo, or
whatever else we require from the network?

Then in task_gui.py and yuminstall.py, we probably can get away with
just checking network.hasActiveNetDev.  Actually, it probably makes
sense to condense the million places we're doing this check down into a
single method somewhere.  I thought it was bad when I was doing it, and
seeing additions just makes it even more obvious.

- Chris