[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [PATCH 1/5] Add function udev_device_get_lv_attr to retrieve lv attribute strings.
- From: Chris Lumens <clumens redhat com>
- To: anaconda-devel-list redhat com
- Subject: Re: [PATCH 1/5] Add function udev_device_get_lv_attr to retrieve lv attribute strings.
- Date: Mon, 21 Sep 2009 14:07:04 -0400
> --- a/storage/udev.py
> +++ b/storage/udev.py
> @@ -261,6 +261,14 @@ def udev_device_get_lv_sizes(info):
>
> return [float(s) / 1024 for s in sizes]
>
> +def udev_device_get_lv_attr(info):
> + attr = info['LVM2_LV_ATTR']
> + if not attr:
> + attr = []
> + elif not isinstance(attr, list):
> + attr = [attr]
> + return attr
> +
> def udev_device_is_biosraid(info):
> # Note that this function does *not* identify raid sets.
> # Tests to see if device is parto of a dmraid set.
You could probably still get a KeyError when you look up LVM2_LV_ATTR,
right? So, how about:
attr = info.get("LVM2_LV_ATTR", [])
to replace the first three lines? I know you use this idiom in plenty
of other places.
- Chris
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]