[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 14/14] Handle Installation Repo (base repo) as any other in repo edit UI.



> @@ -298,7 +282,17 @@ class RepoEditor:
>                                        "and try again."))
>              return False
>  
> -        return setupBaseRepo(self.anaconda, "cdrom:%s" % (cdr,))
> +        log.info("found installation media on %s" % cdr)
> +        repo.name = self.nameEntry.get_text()
> +        repo.anacondabaseurls = ["cdrom:%s" % (cdr,)]
> +        repo.baseurl = "file://%s" % ayum.tree
> +        ayum.mediagrabber = ayum.mediaHandler
> +        self.anaconda.mediaDevice = cdr
> +        ayum.currentMedia = 1
> +        repo.mediaid = getMediaId(ayum.tree)
> +        log.info("set mediaid of repo %s to: %s" % (repo.name, repo.mediaid))
> +
> +        return True

I think you still need to call ayum._switchCD(1) here to preserve the
assumption that the first disc in a set is mounted and that the media
has been verified to be the correct product. This was being called from
setupBaseRepo -> configBaseURL, but you've gotten rid of setupBaseRepo.

Everything else looks okay.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]