Re: [PATCH 0/3] Remove stderr prints from isomd5sum (576251)

["Brian C. Lane" <bcl redhat com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/24/2010 02:35 AM, Radek Vykydal wrote:
> Brian C. Lane wrote:
>> The first patch here removes the stderr prints. The others clean up
>> some things that looked like they needed cleaning up, but aren't
>> directly related to the bug.
>>
>>   
> 
> Hi Brian,
> 
> I have some review acked isomd5sum patches adding symbolic
> constants for return values, but I haven't pushed them yet, so
> you probably don't know about them:
> https://www.redhat.com/archives/anaconda-devel-list/2010-March/msg00230.html
> 

Oh, right! I like the symbolic names better.

> Maybe you could merge your patches 2,3 on top of them?
> 
> I have some comments inline...

If you push your changes I'll re-do my patches on top of your commit. I
agree with all your comments.

Brian

- -- 
Brian C. Lane <bcl redhat com>
Red Hat / Port Orchard, WA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEVAwUBS6o8fRF+jBaO/jp/AQIlvQf/YxAlRuuLGtFHfFAirWj1JA7WKTHdPcBJ
/PR2S1XcYeKsQdlzhECgEZU0x283+0Wc/6bkWO1N9f8NTMWSE10QMaJp1mYbM/LG
2LOq/W/HusPeA+YxmJQK1QStR7NWcAx16Jlb0OSA7ORcSMihcz2haCO2qIk/dPIL
Sl6JlPGVCEqmIsB1WSk6sYWZNspu2+OMpSSKyg2n2MEMGXUp5SHtsYnVQTw4Xi7P
M4vZ9CqR2gXdIIz01r2LBa8p8SV1N+IJbfozapaM4l3wvLAFgS/9Rca3ZIj8sqjK
x09JBARMAPLhzp3bhQ+yn/mazjMZAeILfdDH8kH6WknYyC3hmSgMqw==
=UEhA
-----END PGP SIGNATURE-----