[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
[PATCH 3/3 master] Fix traceback after Delete in nm-c-e (#642370)
- From: Radek Vykydal <rvykydal redhat com>
- To: anaconda-devel-list redhat com
- Subject: [PATCH 3/3 master] Fix traceback after Delete in nm-c-e (#642370)
- Date: Thu, 14 Oct 2010 10:02:37 +0200
The traceback occurs if network enablement is not successful
after deleting a connection in nm-c-e. The reason is that
nm-c-e deletes corresponding ifcfg file. The fix is to update
network object in each iteration of network enablement loop.
---
pyanaconda/gui.py | 13 ++++++++-----
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/pyanaconda/gui.py b/pyanaconda/gui.py
index 8222ea4..48537f7 100755
--- a/pyanaconda/gui.py
+++ b/pyanaconda/gui.py
@@ -902,11 +902,6 @@ class InstallInterface(InstallInterfaceBase):
if len(self.anaconda.network.netdevices) == 0:
return False
- nm_controlled_devices = [devname for (devname, dev)
- in self.anaconda.network.netdevices.items()
- if not dev.usedByFCoE(self.anaconda)]
- if not just_setup and not nm_controlled_devices:
- return False
from iw.network_gui import (runNMCE,
selectInstallNetDeviceDialog,
@@ -915,6 +910,14 @@ class InstallInterface(InstallInterfaceBase):
networkEnabled = False
while not networkEnabled:
+ # We need to do it in each iteration because user can
+ # delete ifcfg file in nm-c-e
+ nm_controlled_devices = [devname for (devname, dev)
+ in self.anaconda.network.netdevices.items()
+ if not dev.usedByFCoE(self.anaconda)]
+ if not just_setup and not nm_controlled_devices:
+ return False
+
if just_setup:
install_device = None
else:
--
1.7.2
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]