[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Create /dev nodes after DUDs are processed (#707563)



> diff --git a/loader2/loader.c b/loader2/loader.c
> index 9729072..78d7ff4 100644
> --- a/loader2/loader.c
> +++ b/loader2/loader.c
> @@ -1741,6 +1741,9 @@ int main(int argc, char ** argv) {
>          mlLoadModuleSet("mlx4_en", modLoaded, modDeps, modInfo);
>      }
>  
> +    /* If we got new devices from the DDs, they need their /dev/node to be created here */
> +    createPartitionNodes();
> +
>      /* JKFIXME: loaderData->ksFile is set to the arg from the command line,
>       * and then getKickstartFile() changes it and sets FL_KICKSTART.  
>       * kind of weird. */

It looks like createPartitionNodes will try to create the device nodes
that have already been created, which will lead to error messages being
logged.  Even though that's not a problem, I can already see the bugs
getting filed about it.  You may want to add a check to createDevNode to
quit if the node already exists.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]