[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [rhel6-branch 1/2] 'part' command checks if media is present.



>  kickstart.py |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/kickstart.py b/kickstart.py
> index 61d00d3..71de65b 100644
> --- a/kickstart.py
> +++ b/kickstart.py
> @@ -811,6 +811,8 @@ class PartitionData(commands.partition.F12_PartData):
>                      disk = mpath_device
>                  if not disk:
>                      raise KickstartValueError, formatErrorMsg(self.lineno, msg="Specified nonexistent disk %s in partition command" % n)
> +                if not disk.mediaPresent:
> +                    raise KickstartValueError, formatErrorMsg(self.lineno, msg="Specified device %s in partition command has no media." % n)

Well, we shouldn't even allow installations onto these sorts of devices
anyway.  I'd suggest some sort of check if disk is an OpticalDevice, or
disk.format is read-only, or something along those lines followed by an
error message like "Cannot install to read-only media".

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]