[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [rhel6-branch 1/2] 'part' command checks if media is present.



On Tue, 2011-06-21 at 09:59 +0200, Ales Kozumplik wrote:
> On 06/20/2011 05:39 PM, Chris Lumens wrote:
> 
> > Well, we shouldn't even allow installations onto these sorts of devices
> > anyway.  I'd suggest some sort of check if disk is an OpticalDevice, or
> > disk.format is read-only, or something along those lines followed by an
> > error message like "Cannot install to read-only media".
> >
> 
> Thanks for catching this, the current patch will allow sr0 with a media 
> in it to be used in 'part'. I don't think that device.format is of much 
> help here --- if no media is present I think the format will be just 
> 'DeviceFormat' which is perfectly OK for partitioning (same as empty 
> device). I suggest testing the device for both .isDisk and 
> .mediaPresent, just like storage.disks() (used by clearpart gui for 
> instance) does.

If the ks commands are trying to create/access partitions on these
devices you probably want to check device.partitionable and perhaps also
device.partitioned, depending on the timing/sequencing.

Dave

> 
> Ales
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]