[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/2] Remove 'Back' button on depsolving exception for ks installs (#673170)



"Brian C. Lane" <bcl redhat com> wrote:

> On Tue, Mar 01, 2011 at 09:36:44PM -1000, David Cantrell wrote:
> > For kickstart installs, the storage changes have already been committed
> > to disk by the time we run in to the depsolving exception window.  Do
> > not offer the 'Back' button for kickstart installs since you can't go
> > back from here.  Only way out is to Continue or exit.
> > ---
> >  yuminstall.py |   11 +++++++----
> >  1 files changed, 7 insertions(+), 4 deletions(-)
> > 
> > diff --git a/yuminstall.py b/yuminstall.py
> > index 3e7f90d..8b72d19 100644
> > --- a/yuminstall.py
> > +++ b/yuminstall.py
>
> >                      if rc == 0:
> >                          sys.exit(1)
> > -                    elif rc == 1:
> > +                    elif rc == 1 and len(custom_buttons) == 3:
>
> Would making this 'and not anaconda.isKickstart' workat this point? I'd
> rather see the source of the logic used in the test than a by-product of
> it.

Yeah, that makes more sense.  Changed to:

-                    elif rc == 1:
+                    elif rc == 1 and not anaconda.isKickstart:

Thanks,

-- 
David Cantrell <dcantrell redhat com>
Supervisor, Installer Engineering Team
Red Hat, Inc. | Honolulu, HI | UTC-10


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]