[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/9] Fix md array spares test.



David Lehman <dlehman redhat com> wrote:

> While still finding the array members the spares calculation can yield
> a negative value, so the test must explicitly check for greater-than-
> zero instead of just non-zero.
>
> Related: rhbz#652874

Ack for rhel6-branch too.

> Related: rhbz#678689
> ---
>  pyanaconda/storage/devices.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/pyanaconda/storage/devices.py b/pyanaconda/storage/devices.py
> index 76d5ad0..0b6903b 100644
> --- a/pyanaconda/storage/devices.py
> +++ b/pyanaconda/storage/devices.py
> @@ -2817,7 +2817,7 @@ class MDRaidArrayDevice(StorageDevice):
>          device.setup()
>          udev_settle()
>  
> -        if self.spares:
> +        if self.spares > 0:
>              # mdadm doesn't like it when you try to incrementally add spares
>              return
>  
> -- 
> 1.7.3.5
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
David Cantrell <dcantrell redhat com>
Supervisor, Installer Engineering Team
Red Hat, Inc. | Honolulu, HI | UTC-10


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]