[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH master] Anaconda processing 'bootif' value of kickstart network --device fixed (#681803)



> diff --git a/pyanaconda/kickstart.py b/pyanaconda/kickstart.py
> index 3123dc3..4c9fcca 100644
> --- a/pyanaconda/kickstart.py
> +++ b/pyanaconda/kickstart.py
> @@ -600,6 +600,14 @@ class NetworkData(commands.network.F8_NetworkData):
>                       (device, msg))
>          else:
>              device = self.device
> +            
> +        # If 'bootif' value of network --device is used use MAC address
> +        # from cmdline remove "01-" from start and edit value for further
> +        # processing
> +        if self.device.lower() == "bootif":
> +            device = flags.cmdline["BOOTIF"][3:] 
> +            device = device.replace("-",":") 
> +            log.info("bootif in kickstart used, transforming to MAC address")
>  
>          # If we were given a network device name, grab the device object.
>          # If we were given a MAC address, resolve that to a device name

You want this indented under the "else:" that's right above since you're
assuming self.device exists, which is not guaranteed.  And I'm not
really a fan of yet more logging here.  But otherwise, I'll push.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]