[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/2] Don't fatal_error if remounting root read-write fails



On Wed, 2011-03-09 at 15:52 -0500, Chris Lumens wrote:
> > As long as we can write to a few places (e.g. /etc, /var, /tmp) it's OK
> > if the root filesystem is readonly. Remove the fatal error if the mount
> > fails. Also clean up the mount call a bit - MS_MGC_VAL hasn't been
> > required since kernel 2.4...
> 
> As long as mount(2) isn't marked with warn_unused_result, ACK to both of
> these.  For what it's worth, I've gotten rid of all this stuff on my
> no-init branch (though, that's a long ways from being merged in).

I applied these patches to f15-branch and everything built and ran OK -
I guess warn_unused_result would have resulted in compile failure?

Anyway, as mentioned on IRC, these patches are intended for master, but
they're also groundwork for the anaconda-as-squashfs-live-image stuff. 

If memory usage becomes an F15 blocker we might need to cherry-pick them
both into f15-branch, once the lorax patches are ready.

-w


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]