[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

grubby: linking to glib-2.0



Hi,

I've noticed that grubby's Makefile links to glib-2.0, but it does not seem to be needed at all:

# git diff
diff --git a/Makefile b/Makefile
index f13f330..8b188f1 100644
--- a/Makefile
+++ b/Makefile
@@ -27,7 +27,6 @@ CFLAGS += $(RPM_OPT_FLAGS) -std=gnu99 -Wall -Werror -Wno-error=unused-function -
 LDFLAGS :=

 grubby_LIBS = -lblkid -lpopt
-grubby_LIBS += $(shell pkg-config --libs glib-2.0)

 all: grubby


# make
gcc -std=gnu99 -Wall -Werror -Wno-error=unused-function -Wno-unused-function -ggdb -DVERSION='"8.3"' -c -o grubby.o grubby.c gcc -std=gnu99 -Wall -Werror -Wno-error=unused-function -Wno-unused-function -ggdb -o grubby grubby.o -lblkid -lpopt


Any not-so-obvious reasons for that? Care for a formal patch?

Cheers.
CR.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]