[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH rhel5-branch] Ignore duplicate opening of installed rpm package file (#506361).



On Fri, Nov 11, 2011 at 10:55:09AM +0100, Radek Vykydal wrote:
> This is second take on the fix, the first one broke some other
> methods of installation (bug #752507)
> The patch is relative to 5.7 not to the previous take.
> 
> Yum calls open file callback twice when installing some packages which
> makes our callback try second download and fail in specific
> case of nfs: method and http: additional repository.
> 
> The fail is caused by self.method.unlinkFilename(fn) in
> RPMCALLBACK_INST_CLOSE_FILE being driven by method (i.e. do nothing
> for nfs, remove rpm file from cache for http), not by repo in question.
> In the problematic case the package of additional http repository
> is not removed from cache because the install method is nfs.
> As a consequence, in the second call of RPMCALLBACK_INST_OPEN_FILE
> repo.getPackage(po) fails to download the package.
> 
> The second call of the OPEN_FILE callback is a bug in yum.

This looks good to me.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Attachment: pgpwPKD8Qiula.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]