Re: req for testers: 2.2.x fbcon alpha fixes

[Jurgen Kramer <GTM Kramer inter nl net>]

Hi,

Unfortunately it still doesn't work. The funtion writel_na and relatives are all
external funtions and can not be found by the linker. Here is the output:

<snip>
make all_targets
make[3]: Entering directory `/usr/src/linux-2.2/drivers/video'
gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -O2
-fomit-frame-pointer -pipe -mno-fp-regs -ffixed-8 -mcpu=ev56 -Wa,-m21164a
-DBWIO_ENABLED   -DEXPORT_SYMTAB -c fbcon.c
fbcon.c: In function `fbcon_show_logo':
fbcon.c:2050: warning: implicit declaration of function `writel_na'
fbcon.c:2058: warning: passing arg 2 of `pyxis_bw_writeb' makes integer from pointer
without a cast
fbcon.c:2080: warning: passing arg 2 of `pyxis_bw_writeb' makes integer from pointer
without a cast
fbcon.c:2090: warning: passing arg 2 of `pyxis_bw_writeb' makes integer from pointer
without a cast
fbcon.c:2132: warning: passing arg 2 of `pyxis_bw_writeb' makes integer from pointer
without a cast
fbcon.c:2161: warning: passing arg 2 of `pyxis_bw_writeb' makes integer from pointer
without a cast
gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -O2
-fomit-frame-pointer -pipe -mno-fp-regs -ffixed-8 -mcpu=ev56 -Wa,-m21164a
-DBWIO_ENABLED   -DEXPORT_SYMTAB -c fbmem.c
gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -O2
-fomit-frame-pointer -pipe -mno-fp-regs -ffixed-8 -mcpu=ev56 -Wa,-m21164a
-DBWIO_ENABLED   -DEXPORT_SYMTAB -c fbcon-cfb8.c
fbcon-cfb8.c: In function `fbcon_cfb8_putc':
fbcon-cfb8.c:136: warning: implicit declaration of function `writel_na'
fbcon-cfb8.c: In function `fbcon_cfb8_revc':
fbcon-cfb8.c:225: warning: implicit declaration of function `readl_na'
gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -O2
-fomit-frame-pointer -pipe -mno-fp-regs -ffixed-8 -mcpu=ev56 -Wa,-m21164a
-DBWIO_ENABLED   -DEXPORT_SYMTAB -c fbcon-cfb16.c
fbcon-cfb16.c: In function `rectfill':
fbcon-cfb16.c:93: warning: implicit declaration of function `writel_na'
fbcon-cfb16.c:99: warning: passing arg 2 of `scr_writew' from incompatible pointer type
fbcon-cfb16.c: In function `fbcon_cfb16_revc':
fbcon-cfb16.c:239: warning: implicit declaration of function `readl_na'
<snip>

I tried to (quickly) locate the real write function but could not find it in all the
_write __write etc. spaghetti.


Jurgen


Jeff Garzik wrote:

> Jurgen Kramer wrote:
> >
> > Hi,
> >
> > I just tested your patch but unfortunately it does not compile. It goes wrong
> > when linking the kernel.
>
> Oops, that is an artifact of a [supposedly] unrelated includes change in
> my tree.
>
> To fix, simply add
>
>         #include <asm/io.h>
>
> to fbcon.c and fbcon-cfb*.c.
>
> I am regenerating the patch, and should be up soon as
> http://havoc.gtf.org/garzik/kernel/files/UNTESTED/2.2.10-fbcon-cfb-alpha-fixes-3.bz2
>
> Thanks!
>
>         Jeff
>
> --
> To unsubscribe: send e-mail to axp-list-request@redhat.com with
> 'unsubscribe' as the subject.  Do not send it to axp-list@redhat.com