[Cluster-devel] Re: [NFS] [RFC PATCH 1/3] NLM lock failover - lock release
Wendy Cheng
wcheng at redhat.com
Fri Jun 30 03:57:10 UTC 2006
On Thu, 2006-06-29 at 19:06 -0400, Trond Myklebust wrote:
> >
> > + /* add server ip for nlm lock failover */
> > + sock->ops->getname(sock, (struct sockaddr *)&daddr, &alen, 0);
> > + rqstp->rq_daddr = daddr.sin_addr.s_addr;
> > +
>
> Hmm.... Why would you want to do this on every receive when you could
> just store the ip address in the struct svc_sock once and for all?
ok, will do that - save latency. Thanks.
>
> That said, how do you envisage this working in the cases where the
> socket is bound to INADDR_ANY?
This is "our" (server's) address, not peer address - for this request to
arrive "here", it can't be INADDR_ANY. Can it ? Remember "rq_daddr" will
only be used during failover in a clustered NFS servers environment.
-- Wendy
More information about the Cluster-devel
mailing list