[Cluster-devel] [PATCH] dlm_controld.pcmk: Fix membership change judging issue
Andrew Beekhof
andrew at beekhof.net
Thu May 13 20:19:58 UTC 2010
On Thu, May 13, 2010 at 8:32 PM, Lars Marowsky-Bree <lmb at novell.com> wrote:
> On 2010-05-13T18:25:42, Andrew Beekhof <andrew at beekhof.net> wrote:
>
>> >> void process_cluster(int ci)
>> >> {
>> >> - ais_dispatch(ais_fd_async, NULL);
>> >> update_cluster();
>> >> }
>> >
>> > Can this function be removed?
>>
>> No, it can't.
>> Remove that and the membership (and crm_peer_id_cache) stops being updated.
>>
>> Which makes me very suspicious of the whole patch because it clearly
>> wasn't tested very well.
>
> ais_dispatch() was moved to update_cluster(). That's safe, it seems.
But pointless and unrelated to the problem, so why include it?
> My question related to the detail that now process_cluster() is
> identical to update_cluster(), at initial reading suggesting the
> function might be redundant now.
process_cluster() and update_cluster() are both API entry points.
Does the behavior still occur with pacemaker 1.1.2?
More information about the Cluster-devel
mailing list