[Cluster-devel] [PATCH] dlm: Allow 64-bit request when CONFIG_COMPAT is on

Jacek Konieczny jajcus at jajcus.net
Tue Feb 19 11:40:50 UTC 2013


Even if kernel is compiled for 32-bit ABI compatibility it still should
able to process 64-bit dlm_write_request struct.
The regression was introduced by:

b75bc91 dlm: check the maximum size of a request from user

Signed-off-by: Jacek Konieczny <jajcus at jajcus.net>
---
 fs/dlm/user.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/dlm/user.c b/fs/dlm/user.c
index 7ff4985..d08a156 100644
--- a/fs/dlm/user.c
+++ b/fs/dlm/user.c
@@ -503,11 +503,7 @@ static ssize_t device_write(struct file *file, const char __user *buf,
 #endif
 		return -EINVAL;
 
-#ifdef CONFIG_COMPAT
-	if (count > sizeof(struct dlm_write_request32) + DLM_RESNAME_MAXLEN)
-#else
 	if (count > sizeof(struct dlm_write_request) + DLM_RESNAME_MAXLEN)
-#endif
 		return -EINVAL;
 
 	kbuf = kzalloc(count + 1, GFP_NOFS);
-- 
1.8.0.1




More information about the Cluster-devel mailing list