[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] Re: 2.6: drivers/md/dm-io.c partially copies bio.c



On Mon, Dec 06 2004, Kevin Corry wrote:
> Hi Adrian,
> 
> On Monday 06 December 2004 6:09 am, Adrian Bunk wrote:
> > drivers/md/dm-io.c copies functionality from bio.c .
> >
> > Is there a specific reason why you don't simply use the functionality
> > bio.c provides?
> 
> Can you give some specific examples of the functionality you think is 
> duplicated? Meanwhile, I'll take a look and see if I can explain any code 
> overlaps.

Ah come on Kevin, a 2 second glance shows lots of uneccesary
duplication. Basically only the concept of the bio_set is not duplicated
in the first many lines, you even set up matching slabs.

How was that ever accepted for merging?

-- 
Jens Axboe


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]