[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] Multipath and HSG80 phase 2



On Thu, Dec 09, 2004 at 12:33:24PM +0100, christophe varoqui free fr wrote:
> >
> > in main.c no zalloc of mpp structure before using it why?
> > in dmparser.c in the merge_words you assume the return of realloc was the
> > same of the passed ptr ?, if it is not the value of p may points to a gangle
> > reference, so you may write a "space" char in an undefined memory
> > location...
> >
> Please send a patch for review.
> 
> AFAICS, the realloc call is good.
> As for main.c, which function do you refer to ?
> 
I have already sent Christophe a patch for this.  The problem was he set p,
moved p, realloced dst, and expected dst to start at the same memory
locating it was at before reallocing, which may or may not be true.  The fix
moves the p assignment and movement after the realloc call.

Andy 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]