Re: [dm-devel] 2.6.5-rc1-udm1: Patch 1/3

[Kevin Corry <kevcorry us ibm com>]

On Tuesday 16 March 2004 8:38 am, Joe Thornber wrote:
> http://people.sistina.com/~thornber/dm/patches/2.6-unstable/2.6.5-rc1/2.6.5
>-rc1-udm1.tar.bz2
>
> I think there were some issues with 2.6.4-mm1, the -udm patches haven't
> changed.

PPC-64 generates this somewhat cryptic compiler warning:

  CC      drivers/md/dm-log.o
drivers/md/dm-log.c: In function `count_bits':
drivers/md/dm-log.c:433: warning: passing arg 1 of `find_next_bit' discards qualifiers from pointer target type
drivers/md/dm-log.c:436: warning: passing arg 1 of `find_next_bit' discards qualifiers from pointer target type

Removing the "const" qualifier from dm-log.c::count_bits() eliminates the
warning.

--- diff/drivers/md/dm-log.c	2004-03-16 09:36:52.000000000 -0600
+++ source/drivers/md/dm-log.c	2004-03-16 09:36:38.000000000 -0600
@@ -424,7 +424,7 @@
 	core_dtr(log);
 }
 
-static int count_bits(const unsigned long *addr, unsigned size)
+static int count_bits(unsigned long *addr, unsigned size)
 {
 	/* FIXME: test this */
 #if 1
@@ -469,7 +469,7 @@
 
 	/* copy clean across to sync */
 	memcpy(lc->sync_bits, lc->clean_bits, size);
-	lc->sync_count = count_bits((const unsigned long *) lc->clean_bits, size);
+	lc->sync_count = count_bits((unsigned long *) lc->clean_bits, size);
 
 	/* write the bits */
 	r = write_bits(lc);