[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] directio path-checker for multipath-tools



Sorry I didn't reply earlier.

Nice work.

+       buf = (unsigned char *)malloc(blksize + pgsize);
+       if (!buf){
+               goto out;
+       }

Don't you want to use an oversized buffer instead of malloc'ing in this
code path ?




On jeu, 2005-08-11 at 16:44 +0200, Hannes Reinecke wrote:
> Hi Christophe,
> 
> I've implemented yet another path checker, based on O_DIRECT.
> Rationale: On S/390 it's possible to activate multipath support for DASD
> devices (called Parallel Access Volume (PAV)). As these are no SCSI
> devices the readsector0 path checker wouldn't work.
> And as this checker is quite generic it'll work for just about anybody.
> 
> Cheers,
> 
> Hannes
> --
> dm-devel mailing list
> dm-devel redhat com
> https://www.redhat.com/mailman/listinfo/dm-devel
-- 
christophe varoqui <christophe varoqui free fr>



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]