[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] PATCH - pvmove doesn't terminate sometimes on 64-bit bigendian machines



Neil Brown wrote:
> On Wednesday September 28, agk redhat com wrote:
> 
>>On Wed, Sep 14, 2005 at 02:32:59PM +1000, Neil Brown wrote:
>>
>>> It is worth noting that the code uses the same bitsets for in-memory
>>> and on-disk logs.  As these bitsets are host-endian and host-sized,
>>> this means that they cannot safely be moved between computers with
>>> different architectures.  I don't know if the dm doco makes this
>>> clear...
>>
>> 
>>Are you able to try out the (untested) patch from Patrick below?
>>Since the current implementation is broken for 64-bit BE we might
>>as well fix both problems at the same time.
>>
> 
> 
> I've ask the person who reported the problem to test this patch.  I'll
> let you know what eventuates.

Thanks

> ... it's a pity about the 'ext2' appearing in there instead of a more
> sensible 'set_le_bit', isn't it :-(
> 

yes. In some (well, the big-endian) architectures it's called set_le_bit and
#defined to ext2_set_bit, bit the LE architectures just define ext2_set_bit to
be set_bit :(

-- 

patrick


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]