[dm-devel] Re: DM configuration

Stefan Bader Stefan.Bader at de.ibm.com
Mon Oct 10 14:14:46 UTC 2005


Generally I think the shorter keywords make sense and I wouldn't mind if 
their're gone
as long as the old ones stay around. The same would apply to the 
no_path_retry
keyword. I think the features keyword should still be accepted for 
compatibility 
reasons. The difficult part there would be what to do if someone uses 
both...

Regards,
Stefan Bader

SW Linux on zSeries Development & Services
Stefan.Bader at de.ibm.com
----------------------------------------------------------------------------------
  When all other means of communication fail, try words.

dm-devel-bounces at redhat.com wrote on 08.10.2005 00:56:50:

> 
> > > diff -rup git/libmultipath/config.h 
retry-multipathd/libmultipath/config.h
> > > --- git/libmultipath/config.h   2005-09-28 12:32:02.000000000 -0400
> > > +++ retry-multipathd/libmultipath/config.h   2005-10-05 18:37:
> 33.000000000 -0400
> > > @@ -33,6 +33,7 @@ struct mpentry {
> > >     int pgpolicy;
> > >     int pgfailback;
> > >     int rr_weight;
> > > +   int no_path_retry;
> > > 
> > >     char * wwid;
> > >     char * selector;
> > > @@ -56,6 +57,7 @@ struct config {
> > >     int pgfailback;
> > >     int remove;
> > >     int rr_weight;
> > > +   int default_no_path_retry;
> > > 
> > the "default_" prefix can be avoided here and in the dictionnary, as 
the
> > default{} block says it all.
> > 
> Speaking of which ...
> 
> Does someone care if I deprecate all "default_foo" in favor of "foo" in
> the default{} dictionnary and 'struct config' ?
> 
> I'll keep the old keyword around, for compat, but undocumented.
> 
> Keywords concerned are :
> 
>         "default_selector"
>         "default_path_grouping_policy"
>         "default_getuid_callout"
>         "default_prio_callout"
>         "default_features"
>         "default_path_checker"
> 
> Regards,
> cvaroqui
> 
> 
> --
> dm-devel mailing list
> dm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel




More information about the dm-devel mailing list