[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] Path check interval in multipathd is 1 second longer



Hi Christophe,

Current path check interval is 1 second longer than polling_interval
setting in multipath.conf.

This bug affects the "no_path_retry" option.
For example, if no_path_retry is set in 1, retry (== path check) will
not be launched in no-path situation.

diff -rup git/multipathd/main.c pathcheck-int-fix/multipathd/main.c
--- git/multipathd/main.c	2005-10-12 10:08:28.000000000 -0400
+++ pathcheck-int-fix/multipathd/main.c	2005-10-12 15:33:13.000000000 -0400
@@ -1175,13 +1175,8 @@ checkerloop (void *ap)
 			if (!pp->mpp)
 				continue;
 
-			if (pp->tick) {
-				/*
-				 * don't check this path yet
-				 */
-				pp->tick--;
-				continue;
-			}
+			if (pp->tick && --pp->tick)
+				continue; /* don't check this path yet */
 
 			/*
 			 * provision a next check soonest,
 
Regards,
Kiyoshi Ueda


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]