[dm-devel] devmapper 1.02.03 breaks ABI

[Bastian Blank]

On Sun, Feb 12, 2006 at 11:23:57AM +0100, Bastian Blank wrote:
> devmapper 1.02.03 breaks the ABI by removing the exported symbol dm_strdup.

The attached patch reexports dm_strdup.

Bastian

-- 
Insufficient facts always invite danger.
		-- Spock, "Space Seed", stardate 3141.9
-------------- next part --------------
=== lib/.exported_symbols
==================================================================
--- lib/.exported_symbols	(revision 226)
+++ lib/.exported_symbols	(local)
@@ -70,6 +70,7 @@
 dm_mknodes
 dm_malloc_aux
 dm_malloc_aux_debug
+dm_strdup
 dm_strdup_aux
 dm_free_aux
 dm_realloc_aux
=== lib/Makefile.in
==================================================================
--- lib/Makefile.in	(revision 226)
+++ lib/Makefile.in	(local)
@@ -23,6 +23,7 @@
 	libdm-common.c \
 	libdm-file.c \
 	libdm-deptree.c \
+	mm/abi.c \
 	mm/dbg_malloc.c \
 	mm/pool.c \
 	$(interface)/libdm-iface.c
=== lib/mm/dbg_malloc.c
==================================================================
--- lib/mm/dbg_malloc.c	(revision 226)
+++ lib/mm/dbg_malloc.c	(local)
@@ -18,6 +18,12 @@
 #include <assert.h>
 #include <stdarg.h>
 
+char *dm_strdup_real(const char *str);
+char *dm_strdup_real(const char *str)
+{
+	return dm_strdup(str);
+}
+
 char *dm_strdup_aux(const char *str)
 {
 	char *ret = dm_malloc(strlen(str) + 1);
=== lib/mm/abi.c
==================================================================
--- lib/mm/abi.c	(revision 226)
+++ lib/mm/abi.c	(local)
@@ -0,0 +1,23 @@
+/*
+ * Copyright (C) 2006 Bastian Blank
+ *
+ * This file is part of the device-mapper userspace tools.
+ *
+ * This copyrighted material is made available to anyone wishing to use,
+ * modify, copy, or redistribute it subject to the terms and conditions
+ * of the GNU General Public License v.2.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+
+#include <stdarg.h>
+
+char *dm_strdup_real(const char *str);
+
+char *dm_strdup(const char *str)
+{
+	return dm_strdup_real(str);
+}
+
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20060212/7e682e9e/attachment.sig>