[dm-devel] Re: [PATCH 6/6] dm to use bd_claim_by_disk

[Jun'ichi Nomura]

Hi Alasdair,

Alasdair G Kergon wrote:
 >>+static int open_dev(struct dm_dev *d, dev_t dev, struct gendisk *holder)
 >>+static int upgrade_mode(struct dm_dev *dd, int new_mode, struct gendisk *holder)
 >>+static void close_dev(struct dm_dev *d, struct gendisk *holder)
 >
 > Please pass the dm structure, struct mapped_device, around between dm functions
 > internally where you can, instead of struct gendisk.  (Every time the new
 > parameter is passed it's wrapped with dm_disk(), so move the dm_disk() inside.)

Thank you for the comment. I changed them and updated the patch.
Could you check whether there is any other wrong thing?

Thanks,
-- 
Jun'ichi Nomura, NEC Solutions (America), Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 06-dm_deptree-2.patch
Type: text/x-patch
Size: 2886 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20060306/b9bd5ae6/attachment.bin>