[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH] Flush deferred queue when dm_suspend() is interrupted



On Thu, Mar 09, 2006 at 06:48:29PM -0500, Jun'ichi Nomura wrote:
> I found in a code review that dm_suspend() doesn't flush
> deferred queue when it's interrupted and failed to suspend.
 
Yup - adding to tree.

> But I don't have a testcase to pick this point

Suspend the device below & issue I/O so the loop won't exit
until you abort the suspend.  That's the reason for that code.

> For the failed dm_suspend() case, there is another problem
> that presuspend is not reverted.

Not a problem yet: no user of that should do anything that needs
reverting should suspension fail, as per the comment (not a FIXME):
       /* This does not get reverted if there's an error later. */

If new targets or enhancements need new hooks then of course
we can consider adding them when the need arises.

Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]