[dm-devel] [PATCH] multipath-tools: fix minor compilation issues

Hannes Reinecke hare at suse.de
Mon Mar 13 12:27:40 UTC 2006


Hi Christophe,

our checker found some minor issues:

- refwwid in libmultipath/configure.c:get_refwwid() might be used
  uninitialized. As dev_type is a simple 'int' there is nothing which
  prevents the unsuspecting user to call it with an unhandled value.
  We shoud rather use an enum and set refwwid to NULL to be on the safe
  side.
- attr in libmultipath/discovery.c:devt2devname() might be used
  uninitialized. Quite unlikely, but might happen in principle.
  So better have it initialized.
- r in multipath/main.c:main() might be used uninitialized.
  True. So have it initialized.

Please apply.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare at suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: multipath-tools-compile-fixes.patch
Type: text/x-patch
Size: 2485 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20060313/c140cda5/attachment.bin>


More information about the dm-devel mailing list