[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH] Fixes for clone_bio and __clone_and_map functions in dm.c



Hi Alasdair,

I found a small bug in the clone_bio() function in dm.c . The number of
bio
vectors in the cloned bio is incorrectly set to the index of the last
bio
vector in its range. I have corrected it in the attached patch.

I don't see that yet - the code is not very transparent though.
(Look at the places that call the function.)

I am a little confused about why is this not a problem. Isn't clone->bi_vcnt supposed to hold the number of bio vectors in the clone? Why does it hold idx+bv_count instead? Please clarify.

Thanks

Abhishek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]