[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
[dm-devel] Re: [PATCH 2.6.19 5/5] fs: freeze_bdev with semaphore not mutex
- From: Alasdair G Kergon <agk redhat com>
- To: David Chinner <dgc sgi com>
- Cc: Andrew Morton <akpm osdl org>, Eric Sandeen <sandeen redhat com>, linux-kernel vger kernel org, "Rafael J. Wysocki" <rjw sisk pl>, dm-devel redhat com, Srinivasa DS <srinivasa in ibm com>, Ingo Molnar <mingo elte hu>, Alasdair G Kergon <agk redhat com>
- Subject: [dm-devel] Re: [PATCH 2.6.19 5/5] fs: freeze_bdev with semaphore not mutex
- Date: Wed, 8 Nov 2006 14:25:11 +0000
On Wed, Nov 08, 2006 at 07:27:22PM +1100, David Chinner wrote:
> But it's trivial to detect this condition - if (sb->s_frozen != SB_UNFROZEN)
> then the filesystem is already frozen and you shouldn't try to freeze
> it again. It's simple to do, and the whole problem then just goes away....
So is that another vote in support of explicitly supporting multiple concurrent
freeze requests, letting them all succeed, and only thawing after the last one
has requested its thaw? (It's not enough just to check SB_UNFROZEN - also need
to track whether any other outstanding requests to avoid risk of it getting
unfrozen while something independent believes it still to be frozen.)
Alasdair
--
agk redhat com
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]