Re: [dm-devel] [PATCH] dm-core-add-ratelimit-printing.patch

[Olaf Kirch <okir lst de>]

On Thursday 05 April 2007 18:36, Jonathan Brassow wrote:
>  #define DMERR(f, arg...) printk(KERN_ERR DM_NAME ": " DM_MSG_PREFIX ": " f "\n", ## arg)
> +#define DMERR_LIMIT(f, arg...) \
> +	if (printk_ratelimit())	\
> +		printk(KERN_ERR DM_NAME ": " DM_MSG_PREFIX ": " f "\n", ## arg)

I would put a "do { ... } while (0)" around this, else you end up with nasty surprises
if it's used as in "if (..) DMERR_LIMIT(..) else do_something"

Olaf
-- 
Olaf Kirch  |  --- o --- Nous sommes du soleil we love when we play
okir lst de |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax