[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] multipath-tool udev rules require missing dmsetup features



On Sun, Aug 12, 2007 at 06:27:17PM +0200, Guido Guenther wrote:
> +		[state]       = "DM_STATE=\"%s%s\"\n",
> +		[tablestate]  = "DM_TABLE_STATE=\"%s%s%s\"\n",

Why use freetext fields if you can set it in a splitted way?

DM_STATE for example shows both suspended and read-only state without
making in properly parsable.

> +	const char** format = _switches[EXPORT_ARG] ? export_formatstrings 
> +	                                            : info_formatstrings;

const char *const *.

Export without a device name makes no sense.

Bastian

-- 
Landru! Guide us!
		-- A Beta 3-oid, "The Return of the Archons", stardate 3157.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]