[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 1/2] dm: add stripe end_io function and event trigger



On Fri, Dec 07, 2007 at 12:10:51PM -0800, Wood, Brian J wrote:
> +static void trigger_event(struct work_struct *work)

> +	/* Test to see which stripe drive triggered the event. */
> +	for (i = 0; i < sc->stripes; i++) {
> +		memset(dev_path, 0, DEV_STR_LEN);
> +		memcpy(dev_path, "/dev/", len = strlen("/dev/"));
> +		/* Copy name of the drive stored in the gendisk
> structure
> +		 * (this is the same name as what is stored in the
> +		 * /proc and /sysfs filesystems */
> +		memcpy(dev_path+len,
> +			sc->stripe[i].dev->bdev->bd_disk->disk_name,

I'm afraid I don't understand what's going on here.

Inode/name lookups have caused dm plenty of trouble in the past from
memory and locking problems so we go out of our way to avoid them.
Only pre-existing fields (like 'name') should be used as device
references.  (And how does that loop work with the error counting?)

> +	/* Trigger event to let dmeventd daemon know to
> +	 * check device status when stripe's DSO is registered*/

(The kernel is independent of any userspace implementation, so we
avoid references to specific choices of userspace daemons.  You
can however include reference examples like that in the patch header.)

> +	 * disconnected this sets "error == -5" */

The symbolic representation of -5 is?

Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]