Re: [dm-devel] [patch 2/3] dm-netlink: Add support for event functions

[Milan Broz <mbroz redhat com>]

Mike Anderson wrote:
> This patch adds support for the dm_path_event dm_send_event funtions which
> create and send netlink attribute events.
> 
> Signed-off-by: Mike Anderson <andmike us ibm com>

>  int __init dm_netlink_init(void)
>  {
>  	int err;
>  
> +	err = netlink_register_notifier(&dm_netlink_notifier);

Hello Mike,

Just small oversight in code:
modification of destructor missing here
(dm_mod will not load second time after rmmod now)

@@ -94,4 +288,6 @@ int __init dm_netlink_init(void)
 void dm_netlink_exit(void)
 {
 	dme_cache_destroy(&dme_cache);
+	sock_release(dm_netlink_sock->sk_socket);
+	netlink_unregister_notifier(&dm_netlink_notifier);
 }

Milan
--
mbroz redhat com