Re: [dm-devel] [patch 1/3] Extremely basic hp hardware handler (no retries, no error handling, etc).

[Chandra Seetharaman <sekharan us ibm com>]

On Mon, 2007-07-30 at 16:08 -0500, Mike Christie wrote:
> Chandra Seetharaman wrote:
> > Hi Dave,
> > 
> > some coding style related comments (below).
> > 
> 
> 
> >> +	if (!error) {
> >> +		err_flags = 0;
> >> +		DMDEBUG("%s path activation command - success",
> >> +		       	path->dev->name);
> > 
> > Mixed use of space and tab for indentation (many other places too).
> > 
> 
> Where is that rule for this type of plcae?

Documentation/CodingStyle:
"Outside of comments, documentation and except in Kconfig, spaces are
never used for indentation, and the above example is deliberately
broken."

> 
> I think that is fine in those types of places. In fact I would leave it 
> with mixed because that is how the rest of the dm code does it.
> 
> 
> >> +	memset(&req->cmd, 0, BLK_MAX_CDB);
> >> +	req->cmd[0] = START_STOP;
> >> +	req->cmd[4] = 1;
> >> +	req->cmd_len = COMMAND_SIZE(req->cmd[0]);
> >> + out:
> > 
> > I think there will be no space before the label (one more below).
> > 
> 
> Either is normally fine, but in this case to fit with the other dm code 
> that is best.

It is not explicitly stated in CodingStyle. But, the example under
"goto" section does have the label start at column 0 (that is why I said
"I think" :).


-- 

----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - sekharan us ibm com   |      .......you may get it.
----------------------------------------------------------------------