[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[dm-devel] Re: 2.6.24.2: 4KSTACKS + pcdrw + dm + mount -> stack overflow: ide-cd related? dm-related?



On Tue 26-02-08 12:37:17, Jiri Kosina wrote:
> On Tue, 26 Feb 2008, Ingo Molnar wrote:
> 
> > > +	name = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL);
> > > +	fname = kmalloc(sizeof(char) * UDF_NAME_LEN, GFP_KERNEL);
> > > +
> > > +	if (!name || !fname) {
> > > +		*err = -ENOMEM;
> > > +		return NULL;
> > > +	}
> > > +
> > >  	if (dentry) {
> > >  		if (!dentry->d_name.len) {
> > >  			*err = -EINVAL;
> > this bit is missing i think:
> > 	if (name)
> > 		kfree(name);
> > 	if (fname)
> > 		kfree(fname);
> 
> Ergh, of course, stupid me, sorry, it should be freed on all exit paths. I 
> am not sending updated patch, as Jan is probably working on complete 
> removal of one of those fields ... ?
  Yes, I'll convert one variable to kmalloc and the other one remove
completely. Stay tuned ;).

								Honza
-- 
Jan Kara <jack suse cz>
SUSE Labs, CR


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]