[dm-devel] Re: [PATCH 1/9] scsi_dh: Implement common device table handling

[Hannes Reinecke <hare suse de>]

Hi Chandra,

Chandra Seetharaman wrote:
> Other than one minor issue the code looks good (sorry for the late
> realization on my part).
>
> Issue: scsi_dh_handler_detach() references scsi_dh with no check for
> null and scsi_dh_notifier() call it with scsi_dh == NULL. code can be
> changed to get the device handler from sdev.
This is fixed in patch 7/9. I thought I had rediffed them properly,
but apparently not. Sorry for that.

Thanks for the review.

Cheers,

Hannes
--
Dr. Hannes Reinecke		      zSeries & Storage
hare suse de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)