Re: [dm-devel] [PATCH] Check region size during dirty log creation

[Alasdair G Kergon <agk redhat com>]

On Wed, Oct 29, 2008 at 02:02:08PM +0100, Heinz Mauelshagen wrote:
> This patch adds checks to the dirty log creation for region size to be
> larger than 2 sectors and to be a power of 2.
 
Interesting we didn't validate that, but the userspace validation is
tighter.

        if (lp->region_size % (pagesize >> SECTOR_SHIFT)) {
                log_error("Region size (%" PRIu32 ") must be a multiple of "
                          "machine memory page size (%d)",
                          lp->region_size, pagesize >> SECTOR_SHIFT);

The validation should be consistent between userspace and kernel.

Alasdair
-- 
agk redhat com