[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [dm-devel] [PATCH 1/9] dm snapshot: make chunk_io handle any buffer



On Mon, Oct 27, 2008 at 09:07:48PM +0900, FUJITA Tomonori wrote:
> chunk_io() can perform I/Os only with ps->area. This patch adds a new
> argument (a pointer to a buffer) to chunk_io() so that it can performs
> I/Os with the buffer.
 
> +static int chunk_io(struct pstore *ps, chunk_t chunk, int rw, int metadata,
> +		    void *data)

data is part of ps so should not need passing in as it's already accessible!

It's looking like struct pstore is acquiring fields that apply to only one
type of snapshot:  IOW More-invasive refactoring of that struct is needed.
- Which fields apply to both?  Which apply only to one type of snapshot?

Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]