[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
[dm-devel] Re: [PATCH 1/10] VFS: Fix error handling of write_super_lockfs/unlockfs
- From: Christoph Hellwig <hch infradead org>
- To: Takashi Sato <t-sato yk jp nec com>
- Cc: "axboe kernel dk" <axboe kernel dk>, "mtk manpages googlemail com" <mtk manpages googlemail com>, "linux-kernel vger kernel org" <linux-kernel vger kernel org>, "xfs oss sgi com" <xfs oss sgi com>, Christoph Hellwig <hch infradead org>, "dm-devel redhat com" <dm-devel redhat com>, "viro ZenIV linux org uk" <viro ZenIV linux org uk>, "linux-fsdevel vger kernel org" <linux-fsdevel vger kernel org>, Andrew Morton <akpm linux-foundation org>, "linux-ext4 vger kernel org" <linux-ext4 vger kernel org>
- Subject: [dm-devel] Re: [PATCH 1/10] VFS: Fix error handling of write_super_lockfs/unlockfs
- Date: Mon, 22 Sep 2008 06:59:56 -0400
On Mon, Sep 22, 2008 at 07:55:26PM +0900, Takashi Sato wrote:
> I've changed the type of write_super_lockfs and unlockfs from "void" to
> "int" so that they can return an error.
Returning an error from the freeze operation makes sense, but for the
unfreeze I don't see the point. You must however change all existing
instances to actually return a value (even if it's always 0 for now)
to avoid breaking git bisect.
If you touch all instances anyway, it would be nice to rename them
to freeze / unfreze as the current names are more confusing.
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]